The newly relaesed version of brat had (as expected some problems) a) I had forgotten to add a module to the code that would therefore not compile. b) The code BrDetctorVolume update introduced by Pawel did only work correctly when the volume had phi>90 i.e. placed on the FS side of the beam. - I did not catch the error until get crazy results out of MRS tracking this afternoon - It could have been caught had I (and before then Pawel) bothered to run the test programs before committing. The detectorvolume test program in fact gave a message -- failed!! This is a lesson to all - please recall to run available testprograms when base classes are created, and d also make new one for addititons. This is a good way to ensure that modifications do not break existing classes and can find problems. Tests scripts and programs is one foundation of good programming techniques. regards and happy fall. ------------------------------------------------------ Flemming Videbaek Physics Department Brookhaven National Laboratory tlf: 631-344-4106 fax 631-344-1334 e-mail: videbaek@bnl.gov
This archive was generated by hypermail 2b30 : Sun Sep 23 2001 - 20:24:03 EDT