Hi Andrey, On Fri, 3 Aug 2001 19:28:35 -0400 (EDT) Andrey Makeev <makeev_a@rcf2.rhic.bnl.gov> wrote concerning ": updated BrZdcRdoModule": > Hi, > > I have commited to BRAT CVS new versions of > BrZdcRdo and BrZdcRdoModule classes and > added ZDC calibration parameters class > BrCalibrationParamsZDC in /brat/data/calib. ^^^^^^^^^^^^^^^^^^^^^^ |||||||||||||||||||||| Please change that to BrZdcCalibration ASAP!!! See also http://www.rhic.bnl.gov/brahms/WWW/private/list_hyper/brahms-soft-l/0183.html > Since I changed the methods names in BrZdcRdo > (sorry for this inconvenience, this is the last change > of names in ZDC) I did change the methods giving > the time from ZDCs in BrVertexModule.cxx file. > > The new ZDC RDO module has now the data from > "low-gain" ADC. The BrZdcRdoModule can return > both digitized and calibrated data (as previous one), ^^^^^^^^^ ||||||||| What? As in digitized (smeared) GEANT output? I should think that was the job of BrZdcDigModule and not the Rdo module. Or do you mean the actual input used by the BrZdcRdoModule (from either the DAQ or from BrZdcDigModule)? > // z-vertex > > GetZ (); >From the perspective of modularity, I believe it be a good thing to seperate out the vertex determination from the RDO module and make a new module called BrZdcVertexModule, using the BrZdcRdo data to make an BrVertex module. I believe a similar approach is on the way for the Beam-Beam counters. While on the subject, I'd really like to see BrVertexModule turned into a proper package (it's not a module - it's a package). Who ever did that module in the first place, could you look into it please? If the vertex determination is seperated out of the ZDC and BB RDO codes, it'll be extremly easy to make a BrVertexPackage: It should only contain a BrZdcVertexModule, BrBbVertexModule, BrTpm1ClusterVertexModule, BrTpm1TrackVertexModule, and perhaps a BrSumVertexModule, the last being a small module that will try to make the best possible vertex from all of the other methods. > At the moment BrZdcRdoModule uses hardcoded calibration > parameters which were taken from 65 GeV data. This should not > affect timing (and z-vertex) calculations. However the absolute > z-position changed since ZDC cables (from IR to FEH) were changed, so > we need to re-adjust the constant offset term by comparison with TPM1. Preferably that should be a parameter in the BrZdcCalibration, and not be a parameter of the module. > When I'll succeed with getting pedestals and will have more > data from left ZDC (which now is connected properly) I'll do new > calibration and Michael will put new numbers in a database. The database at rcas0005.rcf.bnl.gov!!! Please. As a side-note on this: I'm preparing to put in the old calibrations for the TMA and SMA very soon (next week I think). I'm tiding up the Br[Tile|Si]CentCalModule, which is holding me back a little. Hopefully Steve and Hiro will produce some calibration modules so that it should be easy to do all the TMA and SMA calibrations. Yours, Christian ----------------------------------------------------------- Holm Christensen Phone: (+45) 35 35 96 91 Sankt Hansgade 23, 1. th. Office: (+45) 353 25 305 DK-2200 Copenhagen N Web: www.nbi.dk/~cholm Denmark Email: cholm@nbi.dk
This archive was generated by hypermail 2b30 : Sat Aug 04 2001 - 08:34:25 EDT