Hi Steve et al, On Tue, 8 May 2001 13:19:35 -0500 "Sanders, Stephen J" <ssanders@ku.edu> wrote concerning ": RE: FW: Proposal to change BrSiRdo and BTileRdo - once again!": > Hi Christian et al., > I don't see a problem with the new scheme. Your example pretty > much tells me what I need to know for changing my own programs, and > it doesn't look like it will take much effort. Ok. Good. However, I'll probably make the new classes nested, and maybe introduce a common base class. Anyway, this will only affect my previous example slightly: The lines TIter next(&tiles); BrTileChannelRdo* chRdo = 0; while((chRdo = (BrTileChannelRdo*)next())) tileMultHist->Fill(chRdo->fAdcChannelNo, chRdo->fMultiplicity); would then be TIter next(&tiles); BrTileRdo::BrChannel* chRdo = 0; while((chRdo = (BrTileRdo::BrChannel*)next())) tileMultHist->Fill(chRdo->fAdcChannelNo, chRdo->fMultiplicity); or if I can get the commen base class (BrMultRdo) thing goin, then TIter next(&tiles); BrMultRdo::BrChannel* chRdo = 0; while((chRdo = (BrMultRdo::BrChannel*)next())) tileMultHist->Fill(chRdo->fAdcChannelNo, chRdo->fMultiplicity); Notice that the class BrChannel is in the namespace of BrTileRdo (or BrMultRdo) so there's little need in terms of clarity for the longer names I previously suggested. > I don't fully follow the discussion between you and Kris, but I > don't have any objections to the changes that you propose. Don't worry, neither do I from time to time :-) > You might also want to take this opportunity to remove the > BrRdoMultModule. The module will no longer work and, from my > perspective, it has served its purpose of allowing me to familiarize > myself with and to check the output of the new mult classes. Ok. > I believe Bjorn is the only person to indicate that they ever used > this module and, from his last note, it looks like he has also > migrated to the new classes (Bjorn--or anyone else-- correct me if > I'm wrong!). What say you Bjorn? I'll look into it no earlier than friday, so if any one has a problem, tomorrow will be a good day (and do please remember the timezone difference of 6 hours to BNL). Yours, Christian ----------------------------------------------------------- Holm Christensen Phone: (+45) 35 35 96 91 Sankt Hansgade 23, 1. th. Office: (+45) 353 25 305 DK-2200 Copenhagen N Web: www.nbi.dk/~cholm Denmark Email: cholm@nbi.dk
This archive was generated by hypermail 2b29 : Wed May 09 2001 - 12:58:01 EDT