Hi Bjorn, On Tue, 7 Nov 2000 11:56:10 -0500 (EST) Bjorn H Samset <bjornhs@rcf.rhic.bnl.gov> wrote concerning ": Important vtx-update! PLEASE READ!": > (Christian: You made some changes in this module to make it compile under > WinDoze - since I do not know just what that was I may have destroyed > these. Please check!) What I probably did, was to move loop variables out of the loop scope, since MicroS**t Visual F**k++ (incorrectly) believes it's an errror. This goes for EVERYONE: Please refer to previous mail on brahms-dev-l http://www.rhic.bnl.gov/brahms/WWW/private/list_hyper/brahms-dev-l/0519.html Further, I have some comments on BrVertexModule. Please note, however, that the suggestions given, are not implementable yet!!! The long awaited BRAT revision is needed! First off. Good job. Second of: BrVertexModule, is an example of what I like to term a `Package', that is, a specialised collection of modules, rather then a module. Therefore, it should inherit from BrModuleContainer, rather then from BrModule. Continuing this line of thought, I suggest you use the name `BrVertexPackage', so that it's plain as day, that it's not really a module. BrVertexModule should be an Abstract Base Class (ABC) for all modules that will create a BrVertex data object. Hence, BrVertexPackage will contain BrVertexModule pointers, that may point to BrVertexModuleBB, BrVertexModuleTMP1Cluster, BrVertexModuleTMP1Track, BrVertexModuleZDC, and so on. Similar points go for BrLocalTrackModule BrBrLocalTrackModuleTPC BrLocalTrackModuleDC BrLocalTrackPackage BrClusterModule BrClusterModuleTPC BrClusterModuleDC BrClusterPackage BrCherenkovModule BrCherenkovModuleC1 BrCherenkovModuleRICH BrCherenkovModuleGASC BrCherenkovPackage BrMultiplicityModule BrMultiplicityModuleTILE BrMultiplicityModuleSI, BrMultiplicityModuleZDC BrMultiplicityPackage and so on. (If you believe this is a load of BS, please tell me your secret, 'cause I can't make heads and tails of all the classes in BRAT!) I plan to write a document describing my ideas for revisiting BRAT, including such reorganization of Modules, Contaiers, and packages. I hope to make it avaliable for the collaboration meeting, but since I'm going on vacation next week (so sunny Scotland - and if you believe that, you probably also believe BRAT has no bugs!), I may not be able to make it. Yours, Christian ----------------------------------------------------------- Holm Christensen Phone: (+45) 35 35 96 91 Sankt Hansgade 23, 1. th. Office: (+45) 353 25 305 DK-2200 Copenhagen N Web: www.nbi.dk/~cholm Denmark Email: cholm@nbi.dk
This archive was generated by hypermail 2b29 : Tue Nov 07 2000 - 12:44:06 EST