I was prompted by this note to the list, as well as recent reading of code recently to come with the observation that we are NOT dealing nicely with the eventnodes (inNode and outNode) in increasingly many modules. It has now become common place in code to have statements like if datatable not in inNode the look in outNode. And I have even seen adding the outputtable to both inNode and outNode. It is obvious why this happens - some early module in the chain write a rdo-objet to the outNode while some subsequent code then wants to use this for analysis. This early lead to CH's invention of the swithccontainer (that supplie outNode as both inpput and outoput to a module but this does not solve all.) . I added the AppendContainer that within the container add's the outNode to the Innode, and then drops the pointer later. Both these methods have the potential problem that the same dataobjects are pointed through two different chains i.e. both in inNode and outNode. I do not have a clear solution to this, but will state that making every module add a peice of code to look for both in and out is silly.One though namely to 'append out' by defaullt in the main module also has its problem (I do not think this will work with input/modules, unless we make input have the syntax Event(dummy, event) ). There might well be other cases where one could get into problems. I think always using Append or Switch appropriate for a given solution is a better scheme than the multiple coding. Flemming ------------------------------------------------------ Flemming Videbaek Physics Department Brookhaven National Laboratory tlf: 631-344-4106 fax 631-344-1334 e-mail: videbaek@bnl.gov ----- Original Message ----- From: "Jens Ivar Jordre" <jensivar.jordre@fi.uib.no> To: <brahms-soft-l@bnl.gov> Sent: Thursday, December 06, 2001 2:52 PM Subject: Minor change to BrMrsTrackingModule > Howdy brats. > > I just checked in some minor changes in BrMrsTrackingModule::Event. This > member function differed from BrFfsTrackingModule::Event by a.o. not > checking the output node for data table "DetectorTrack <TPC name>" if > not found in the input node. Now it does. > > No revision bump or new tag. > > Best wishes from > Jens Ivar > > -- > Jens Ivar Jřrdre > e-mail: JensIvar.Jordre@fi.uib.no > usually: Dep. of Phys., Allégt. 55, N-5007 BERGEN, NORWAY > currently: Bldg 510D, P.O.Box 5000, Upton, NY 11973-5000, USA > phone: +1-631-344-4223 > > >
This archive was generated by hypermail 2b30 : Sat Dec 08 2001 - 17:35:04 EST