Hi Jens Ivar, On Fri, 24 Aug 2001 09:18:48 -0100 (GMT+1) Jens Ivar Jordre <jens@fi.uib.no> wrote concerning "BrTpcPedestalModule": > Howdy brats. > > I've made a module for processing TPC pedestal data. Before checking it > into BRAT I should ask if anyone has any opinion as to where this module > should be placed. I wonder if the right place should be a new > <brat source dir>/modules/calib/tpc. If I don't hear/see any objections > I'll put it there in a few hours. If BrTpcPedestalModule is a module that makes some sort of calibrations (pedestals for the TPCs? Is there not supposed the be zero suppression in the DAQ? Are the pedestals really used in the reconstruction?) then it should go into modules/calib/tpc AND is should be called BrTpcPedestalCalModule (or shorter BrTpcPedCalModule). I'd like to take this oppertuinity to point out that "The Guide" actually describes this. Perhaps someone at BNL should print 20 copies and glue it onto the pii machines, preferably over the monitor so that you cannot help see it :-). If, on the other hand, the module does _not_ make calibrations, then is should go into some other directory. If it's part of the tracking pass, then modules/track/tpc. If it's more or less stand-alone then in modules/rdo. If it's not used in the tracking/analysis or doesn't make calibrations, then it does not belong in BRAT. Keep it in brahms_app in that case. Keep in mind, that everytime you add a class to BRAT, the "confusion factor" goes up one notch. If the class isn't used, then the confusion factor goes up two notches. This not an argument for making few class that does a lot (quite the opposite in fact), but a reason for people to clean up their sh*t (a couple of directories spring to mind). All that said, I'm glad to see someone is working on making modules that does calibrations. We still need a lot more of those (please consult the TODO file in BRAT). > Best wishes from > Jens Ivar > .....at a boring night shift. No beam whatsoever. Please, questions to brahms-dev-l, announcements to brahms-soft-l. Yours, Christian Holm Christensen ------------------------------------------- Address: Sankt Hansgade 23, 1. th. Phone: (+45) 35 35 96 91 DK-2200 Copenhagen N Cell: (+45) 28 82 16 23 Denmark Office: (+45) 353 25 305 Email: cholm@nbi.dk Web: www.nbi.dk/~cholm
This archive was generated by hypermail 2b30 : Fri Aug 24 2001 - 04:39:04 EDT