Hi all, I've commited some (rather many in fact) minor changes to BRAT, and one major change. The major change is the change to BrEventIO. Notice also the change to BrMainModule. TObjectTable is an invaluable tool for finding memory leaks. I've not tagged the CVS, since Djam tells me he'll do that later this evening. >From the ChangeLog: ------------------- 2001-08-21 Christian Holm Christensen <cholm@rcas0009.rcf.bnl.gov> * data/abc/BrEvent.h: Minor fixes. * data/abc/BrEvent.cxx: small changes * data/abc/BrEventNode.cxx: Added method CheckLis for on-demand allocation. Added some more documentation. Added type-safety to GetDataTable, GetEventNode methods. * data/abc/BrEventNode.h: Added method CheckLis for on-demand allocation, and moved inline methods out of the class declaration. * data/abc/BrEventHeader.cxx: Initialise _all_ variables to zero. * data/abc/BrEventHeader.h: Cleaned up. * data/abc/BrEvent.h: Added methos CheckHeade for on-demand creation. Also moved inline methods out of class declaration body and into the end of the file * data/abc/BrEvent.cxx: Introduced the method CheckHeader for the dynamic allocation of BrEventHeader. * modules/abc/BrIOModule.h, modules/abc/BrIOModule.cxx: Made ctor take const char*'s * modules/abc/BrModule.cxx: Tidy up. * modules/io/BrEventIO.cxx: Added a method to set the buffer size and split level on the TTrees. It turned out, that with the default setting (64000, 1), we (@ nbi) got serious problems reading back files. An investigation gave: buffer split 100 2000 4000 6400 16000 32000 0 n/a n/a ok bad n/a n/a 1 ok ok bad bad bad bad 2 ok n/a n/a ok ok ok 3 ok n/a n/a ok ok ok n/a means I was lazy and didn't do the test. I've set the default to 32000/1. See also the ROOT Users Guide chapter 12. * modules/io/BrEventIO.h: Added a method to set the buffer size and split level on the TTrees. It turned out, that with the default setting (64000, 1), we (@ nbi) got serious problems reading back files. An investigation gave: buffer split 100 2000 4000 6400 16000 32000 0 n/a n/a ok bad n/a n/a 2 ok n/a n/a ok ok ok 99 ok n/a n/a ok ok ok n/a means I was lazy and didn't do the test. I've set the default to 32000/1. See also the ROOT Users Guide chapter 12. * modules/util/BrMainModule.cxx: Added print-out from gObjectTable depending on the debug level. Note you can always turn that feature of completly in your .rootrc file. Also, added some documentation. * managers/BrAppOptionManager.cxx, managers/BrAppOptionManager.h: Added member fHasParsed, so that we can check if we've parsed the commandline. Not really needed now, but I left it in anyway. No real harm in that. * configure.in: Whoops, small problem in misspelling. Fixed. * modules/digitize/BrTileDigModule.cxx, modules/digitize/BrSiDigModule.cxx: Increased some debugging levels * Makefile.am: Added TODO to installation documentation sub directory * configure.in: Added config/Makefile to the list of makefiles * config/root.m4: Added RPATH support * Makefile.am: Added TODO to dist * Makefile.am: Added config subdirectory and moved some EXTRA_DIST there * config/Makefile.am: moves EXTRA_DIST of files in this dir from ../Makefile.am * help/xpm.m4, help/root.m4: Removed root.m4 xpm.m4 in favour of the ones in ../config/ * help/brat.m4: Added rpath support * config/Makefile.am: A fix * config/Makefile.am: Added makefile to install aclocal data from this directory. * help/Makefile.am: Only install brat.m4 * help/Makefile.am: Moved the installation of aclocal macros to ../config * config/config.mk: Added ROOTRPATH and -R option for automatic rpath support for the ROOT libraries (still testing it though) * help/root.m4: Added ROOTRPATH * help/brat-help.el: Do not set the version number and help line on BrAppOptionManager. This is done in bratmain now. * applications/bratmain/bratmain.cxx: Better support for options, etc. 2001-08-21 Claus Jorgensen <ekman@rcas0009.rcf.bnl.gov> * data/params/BrChkvParameters.cxx: Changed verbose level in TestRange method. * data/params/BrChkvParameters.cxx: Fixed bug in GetTubeWithDirection() method. 2001-08-20 Christian Holm Christensen <cholm@rcas0009.rcf.bnl.gov> * applications/bratroot/BrRint.cxx: Fixed a problem with dyn path. Yours, Christian Holm Christensen ------------------------------------------- Address: Sankt Hansgade 23, 1. th. Phone: (+45) 35 35 96 91 DK-2200 Copenhagen N Cell: (+45) 28 82 16 23 Denmark Office: (+45) 353 25 305 Email: cholm@nbi.dk Web: www.nbi.dk/~cholm
This archive was generated by hypermail 2b30 : Tue Aug 21 2001 - 12:58:36 EDT