Various BRAT Changes

From: Christian Holm Christensen (cholm@hehi03.nbi.dk)
Date: Fri Aug 10 2001 - 10:51:53 EDT

  • Next message: Flemming Videbaek: "BrTileDigModule"

    Hi all, 
    
    I've commited various BRAT changes today:
    
    2001-08-10  Christian Holm Christensen  <cholm@hilux12.nbi.dk>
    
    	* scripts/showeventfile.C: Some minor fixes
    
    	* modules/util/BrBragHeaderModule.h, modules/util/BrBragHeaderModule.cxx:
    	Added module to copy BRAG header to output.  Histograms of the primary
    	vertexs Z-coordinate and of the impact parameter is also
    	generated.
    
    	* modules/util/BrMainModule.cxx:
    	Main Will return 0 on success (as it should)
    
    	* modules/util/BrCentFilter.h, modules/util/BrCentFilter.cxx:
    	Changed a few things, so that centrality data not present can be
    	ignored, and also added a statistics output (conditional on verbosity
    	level ofcourse).
    
    	* modules/digitize/BrTileDigModule.cxx:
    	Cleaned up this module a lot.  The event method was very inefficient,
    	and there seemed to be a problem with setting the ID in the digit, so
    	that too many channels had ID of 0 (zero).
    
    	* modules/digitize/BrSiDigModule.cxx:
    	Cleaned up the Event method.  This method was very inefficient (many
    	nested loops).  Also removed some erroneous failures (due to missing
    	non-existing geometry data).
    
    	* doc/guide/Makefile.am: Added the WARNINGS to the CLEANFILES
    
    	* doc/guide/.cvsignore: Added DVI file to files that should be ignored
    
    	* doc/guide/Makefile.am: Some fixes for older LaTeX2HTML
    
    	* db/calib/BrDbRevision.cxx: Fix to allow long data arrays in insertion
    
    	* data/rdo/BrTofRdo.cxx, data/rdo/BrMultRdo.h, data/rdo/BrMultRdo.cxx, data/rdo/BrChkvRdo.cxx:
    	Fix to allow putting theses on branch in a new TTree - thanks Rene
    
    	* applications/bratroot/BrRint.cxx:
    	Use gROOT->SetMacroPath to set macro path (thanks Brett).
    
    
    Notice the BrMultRdo, BrTofRdo and BrChkvRdo updates:  Rene Brun
    figured out what was wrong in the example I sent out yesterday
    
      http://www.rhic.bnl.gov/brahms/WWW/private/list_hyper/brahms-soft-l/0197.htm
    
    For more on what happened, please read the method doc of
    TClonesArray::BypassStreamer, and if that doesn't help you, send a
    request to me. 
    
    Also notice the update of Br[Si|Tile]DigModule.  These modules where
    extremly inefficenet, and had erroneous behaviour.   
    
    The SMA digitizer failed (with SIGSEGV) if you set the debug level to
    3 or above, as it would try to print the non-exsisting geometry of the
    SMA. 
    
    The TMA digitizer did not set the ID correctly in the output BrTileDig
    object, wich I believe would cause all kinds of problems for later
    steps.  
    
    bratmain will now return 0 (not 990) on success. 
    
    Yours, 
    
    Christian  -----------------------------------------------------------
    Holm Christensen                             Phone:  (+45) 35 35 96 91 
      Sankt Hansgade 23, 1. th.                  Office: (+45) 353  25 305 
      DK-2200 Copenhagen N                       Web:    www.nbi.dk/~cholm    
      Denmark                                    Email:       cholm@nbi.dk
    



    This archive was generated by hypermail 2b30 : Fri Aug 10 2001 - 10:52:27 EDT