[Brahms-dev-l] [Fwd: Re: Acceptance maps]

Hi,

bug found in FsGeometry.cxx:

//__________________________________________________________________________________
void FsGeometry::CheckTNFidCuts(Int_t i){
  //
  // Check that fidcuts are inside the detectorvolume
  // If not modify to be size of detectorvolume.
  const Float_t *size = fTNVolume[i-1]->GetSize();
  for (Int_t k = 0 ; k < 2; i++)
    {
	.....

notice the for-loop: which increments the "i", and not the "k".
Fixed. Made FS maps without any problem...

And yes be aware that if you do not set any fiducial cut options, the
fiducial cuts will be set to the size of the detector.

banapp new version is 1.2.2, tagged: banapp_1-2-2

Cheers,
	Truls



On Wed, 2007-01-10 at 20:24 -0500, Flemming Videbaek wrote:
> Hi
>  
> This is indeed surpeising; but it could depend on whatever fiducial
> cuts have been applied. Did you overwrite the old maps ?
> The old code certainly had a problem in so far it did not include the
> dead slats in tofw which is crucial for PID, but this effect
> would in fact not lower the yeilds, so my gueass it has to do with
> fiducial cuts. 
> On the FS part I have not tried the new banapp. It sounds we really
> should compare new/old. I still have the old version around
> and have generated maps, so this may be feasible.
> I cc the answer to the list because others may have clues to this, and
> or comments.
>  
> Flemming
>  
> --------------------------------------------
> Flemming Videbaek
> Physics Department 
> Bldg 510-D
> Brookhaven National Laboratory
> Upton, NY11973
>  
> phone: 631-344-4106
> cell:       631-681-1596
> fax:        631-344-1334
> e-mail: videbaek @ bnl gov
>         ----- Original Message ----- 
>         From: Hans Hjersing Dalsgaard 
>         To: Flemming Videbaek 
>         Sent: Wednesday, January 10, 2007 7:18 PM
>         Subject: Acceptance maps
>         
>         
>         Hi Flemming,
>         
>         After generating new MRS maps, my yields in the MRS dropped
>         some 20 % ! The maps I used before were generated half a year
>         ago or something like that....I must admit I was a little
>         surprised. I do not understand how the MRS maps apparently
>         changed so much in this brief time ? 
>         
>         Furthermore, using the latest version of banapp, I am unable
>         to generate FS maps due to some bug in the error minimization.
>         The calculation gets stuck at "nan %" ...so far I have been
>         unable to track the bug. 
>         
>         Do we have some up-to-date maps for the 62 GeV data somewhere
>         on rcas? Using these would rule out any error I might commit
>         in generating the maps....
>         
>         Regards,
>         
>         Hans
> _______________________________________________
> Brahms-dev-l mailing list
> Brahms-dev-l_at_lists.bnl.gov
> http://lists.bnl.gov/mailman/listinfo/brahms-dev-l

_______________________________________________
Brahms-dev-l mailing list
Brahms-dev-l_at_lists.bnl.gov
http://lists.bnl.gov/mailman/listinfo/brahms-dev-l