Hi, yes I agree. And i will definitly not affect FFS/FS analysi. But this could be the reason many of us had to apply a rather severe constraint in the allowed TOFW slat hit/or TPM2 back plane. It will be interesting to see if I can get full coverage of the accmap with the data, without making these constraints... Cheers, Truls On Thu, 2006-12-07 at 07:44 -0500, Flemming Videbaek wrote: > Hi Truls, > > Thanks for finding this - > It is likely not important for anything in the FS since tracks within acceptance > are always with the actual volume of T1..T5. > In MRS, this may in fact not have been a problem either. Only if you also applied the actual cuts > in the analysis (front Tpm1) back (Tpm2) would you see a difference. > > Flemming > > > > -------------------------------------------- > Flemming Videbaek > Physics Department > Bldg 510-D > Brookhaven National Laboratory > Upton, NY11973 > > phone: 631-344-4106 > cell: 631-681-1596 > fax: 631-344-1334 > e-mail: videbaek @ bnl gov > ----- Original Message ----- > From: "Truls Martin Larsen" <trulsml_at_nbi.dk> > To: "Brahms Devel List" <brahms-dev-l_at_lists.bnl.gov> > Sent: Thursday, December 07, 2006 7:02 AM > Subject: [Brahms-dev-l] Bug in brat related to acceptance map generation...brat 2.36.16 > > > > Hi, > > > > I found this snippet of code in BrDetectorVolume: > > > > ########################################################### > > //______________________________________________________________ > > Bool_t BrDetectorVolume::IsInsideX(Float_t x){ > > // > > // Check if the x value is inside the valid range of the > > // box. > > // > > if( (x < fSize[0]/2. ) || ( x > fSize[0])) > > return kTRUE; > > else > > return kFALSE; > > } > > //______________________________________________________________ > > Bool_t BrDetectorVolume::IsInsideY(Float_t y){ > > // > > // Check if the x value is inside the valid range of the > > // box. > > // > > if( (y < fSize[1]/2. ) || ( y > fSize[1])) > > return kTRUE; > > else > > return kFALSE; > > } > > ############################################################### > > > > They don't make much sense to me. I think they should be like this: > > > > ############################################################### > > //______________________________________________________________ > > Bool_t BrDetectorVolume::IsInsideX(Float_t x){ > > // > > // Check if the x value is inside the valid range of the > > // box. > > // > > if (x < -fSize[0]/2. || x > fSize[0]/2) > > return kFALSE; > > > > return kTRUE; > > } > > //______________________________________________________________ > > Bool_t BrDetectorVolume::IsInsideY(Float_t y){ > > // > > // Check if the x value is inside the valid range of the > > // box. > > // > > if (y < -fSize[1]/2. || y > fSize[1]/2) > > return kFALSE; > > > > return kTRUE; > > } > > > > ################################################################# > > > > > > These functions IsInsideX/Y() are used in generateMaps, to check > > if the given fiducal cuts for the tracking chambers are not outside > > the actual volume of the box, and if they are then they are changed > > to the actual volume size of the box. By default all these parameters > > are set to 99 and -99 from the options that generateMaps take, and > > consequently they were not changed!!! When particles swim through the > > boxes all exit and entry points between -99 and 99 are accepted. They > > should only be accepted if they enter the front plane and exit the > > back plane of the box. > > > > > > This has affected all maps generated after the 4. of November 2005! > > > > I have commit this change to BrDetectorVolume.cxx > > > > Brat has new tag and version: 2.36.16 > > > > Cheers, > > Truls > > -- > > *---------------------------------* > > |http://www.nbi.dk/~trulsml / > > |Truls Martin Larsen / > > |trulsml_at_nbi.dk . > > |The Niels Bohr Institute // > > |Work Address: / \0 > > |Blegdamsvej 17 /\_/ > > |DK-2100 Copenhagen / / > > |Tel: +45 353 25269 / -- > > | /_/ | > > |Home address: / \ > > |Holger Danskes Vej 28H| ' > > |DK-2000 Frederiksberg | > > |Denmark | > > |Mob: +45 20974802 | > > *----------------------* > > > > _______________________________________________ > > Brahms-dev-l mailing list > > Brahms-dev-l_at_lists.bnl.gov > > http://lists.bnl.gov/mailman/listinfo/brahms-dev-l > > > _______________________________________________ Brahms-dev-l mailing list Brahms-dev-l_at_lists.bnl.gov http://lists.bnl.gov/mailman/listinfo/brahms-dev-lReceived on Thu Dec 07 2006 - 08:14:01 EST
This archive was generated by hypermail 2.2.0 : Thu Dec 07 2006 - 08:14:25 EST