[Brahms-dev-l] Bug in brat related to acceptance map generation... brat 2.36.16

Hi,

I found this snippet of code in BrDetectorVolume:

###########################################################
//______________________________________________________________
 Bool_t BrDetectorVolume::IsInsideX(Float_t x){
  //
  // Check if the x value is inside the valid range of the
  // box.
  //
  if( (x < fSize[0]/2. ) || ( x > fSize[0]))
    return kTRUE;
  else
    return kFALSE;
}
//______________________________________________________________
 Bool_t BrDetectorVolume::IsInsideY(Float_t y){
  //
  // Check if the x value is inside the valid range of the
  // box.
  //
  if( (y < fSize[1]/2. ) || ( y > fSize[1]))
    return kTRUE;
  else
    return kFALSE;
}
###############################################################

They don't make much sense to me. I think they should be like this:

###############################################################
//______________________________________________________________
Bool_t BrDetectorVolume::IsInsideX(Float_t x){
  //
  // Check if the x value is inside the valid range of the
  // box.
  //
  if (x < -fSize[0]/2. || x > fSize[0]/2)
    return kFALSE;

  return kTRUE;
}
//______________________________________________________________
Bool_t BrDetectorVolume::IsInsideY(Float_t y){
  //
  // Check if the x value is inside the valid range of the
  // box.
  //
  if (y < -fSize[1]/2. || y > fSize[1]/2)
    return kFALSE;

  return kTRUE;
}

#################################################################


These functions IsInsideX/Y() are used in generateMaps, to check
if the given fiducal cuts for the tracking chambers are not outside
the actual volume of the box, and if they are then they are changed
to the actual volume size of the box. By default all these parameters
are set to 99 and -99 from the options that generateMaps take, and
consequently they were not changed!!! When particles swim through the
boxes all exit and entry points between -99 and 99 are accepted. They
should only be accepted if they enter the front plane and exit the
back plane of the box.


This has affected all maps generated after the 4. of November 2005!

I have commit this change to BrDetectorVolume.cxx

Brat has new tag and version: 2.36.16

Cheers,
	Truls
-- 
*---------------------------------*
|http://www.nbi.dk/~trulsml           /
|Truls Martin Larsen                       /
|trulsml_at_nbi.dk                              .
|The Niels Bohr Institute        //
|Work Address:                            / \0
|Blegdamsvej 17                        /\_/
|DK-2100 Copenhagen              /  /
|Tel: +45 353 25269            / --
|                                              /_/  |
|Home address:                  /         \
|Holger Danskes Vej 28H|          '
|DK-2000 Frederiksberg |
|Denmark                             |
|Mob: +45 20974802         |
*----------------------*

_______________________________________________
Brahms-dev-l mailing list
Brahms-dev-l_at_lists.bnl.gov
http://lists.bnl.gov/mailman/listinfo/brahms-dev-l