[Brahms-dev-l] banapp bug fixed...

From: Truls Martin Larsen <trulsml@nbi.dk>
Date: Thu May 11 2006 - 07:16:52 EDT
Hi,

I introduced a bug yesterday. This is the fix. 
Did the classic:

if (slat < fSlatRange[0] || slat > fSlatRange[0])
  return -1;

which would only fail if slat == fSlatRange[0]...

changed to:
if (slat < fSlatRange[0] || slat > fSlatRange[1])

banapp version 1.1.11 commited and tagged.

BTW, running generateMaps with limited number of slats increases the
running time.

Also, the request for a small error in the bins actually is dominated by
the edges in the calculation of the average bin error in the map. If you
request 2% on a standard MRS map, you might get something like 0.3% away
from the edges, and about 10% a the edges. I'm working on a fix to this
behaviour.


Cheers,
	Truls
-- 
*---------------------------------*
|http://www.nbi.dk/~trulsml      /
|Truls Martin Larsen            /
|trulsml@nbi.dk                .
|The Niels Bohr Institute     //
|Work Address:               / \0
|Blegdamsvej 17             /\_/
|DK-2100 Copenhagen        /  /
|Tel: +45 353 25269       / --
|                        /_/  |
|Home address:          /     \
|Holger Danskes Vej 28H|      '
|DK-2000 Frederiksberg |
|Denmark               |
|Mob: +45 20974802     |
*----------------------*

_______________________________________________
Brahms-dev-l mailing list
Brahms-dev-l@lists.bnl.gov
http://lists.bnl.gov/mailman/listinfo/brahms-dev-l
Received on Thu May 11 07:17:32 2006

This archive was generated by hypermail 2.1.8 : Thu May 11 2006 - 07:17:46 EDT