Re: [Brahms-dev-l] tof2 adc gap calibration

I have seen the same problem in several other pieces of code for calibration
. Since at home I will not check,
but there is a problem and it should be fixed.

flemming

----------------------------------------------------------------
Flemming Videbaek
Physics Department
Brookhaven National Laboratory

e-mail: videbaek@bnl.gov
phone: 631-344-4106
----- Original Message ----- 
From: "Hironori Ito" <hito@rcf.rhic.bnl.gov>
To: "devlist" <brahms-dev-l@lists.bnl.gov>
Sent: Thursday, September 09, 2004 7:17 PM
Subject: [Brahms-dev-l] tof2 adc gap calibration


> Hey.  How were we committing TOF AdcGap calibration?  Eun-Joo just asked
> me to commit some AdcGap calibration to our database after she failed to
> do so.  Since I am "nice" (and it did sound very easy), I just tried it
> for run 9500.  It looked like it did except that all entries in our
> database were "-1111" for Run 9500 (adc gap things).   Now, this did not
> really look good since we don't want to have corrupt database.  After
> looking at BRAT code and committing "-1111" values in our database
> several times (I should have comment out BrDbCommitModule for testing),
> I found out the cause of this problem.  It is in
> BrTofAdcGapCalModule::Finish() method.  Here is the problematic (???)
code.
>
>
>   // if load ascii mode
>   if (fLoadAscii || !fFillHistoOnly)     <---------?????  Should this be
>     if (fLoadAscii)
>     return;
>
>   // if commit mode
>   if (fCommitAscii) {
>     ReadAscii();
>     return;
>   }
>
>
> This means that if you just want to commit (without filling histogram)
> values from ascii file, it just never gets to ReadAscii() method, which
> is required.  So, this is my question.  How have you ever committing
> these values?  Anyhow, since I am not TOF expert here, I will stop
> contaminating our TOF2 adc calibration and let our expert to fix this.
> (This means that currently our database value for run 9500 is "-1111"
> for adc gaps.  )
>
> Hiro
>
>


----------------------------------------------------------------------------
----


> _______________________________________________
> Brahms-dev-l mailing list
> Brahms-dev-l@lists.bnl.gov
> http://lists.bnl.gov/mailman/listinfo/brahms-dev-l
>


_______________________________________________
Brahms-dev-l mailing list
Brahms-dev-l@lists.bnl.gov
http://lists.bnl.gov/mailman/listinfo/brahms-dev-l