[Brahms-dev-l] bug in bb calibration modules

Hello.  I think I found the bug in bb calibration module. 

Assuming that slewing calibration is done at first, and then calibrate 
for deltatdc, the following is the problem I found.
In BrBbSlewingCalModule.cxx, it uses DeltaTdc.  Then, in 
BrBbDeltaTdcCalModule.cxx, it uses slewing values.  This is circular.   
If the order of calibration is correct, deltaTdc parameter should not be 
used in slewing.  Or, if the order is incorrect (deltatdc first and 
then, slewing), the slewing parameter should not be used in 
BrBbDeltaTdcCalModule.  (or someone might say, both calibration should 
be done simultaneously with only one offset parameter instead of two 
(DeltaTdc and slewDt), but this is different story. :) )   Anyhow, the 
current module is not quite right. After removing DeltaTdc  parameter 
from slewing calibration code, everything started to work.  Both big and 
small tubes produce the reasonable vertex with their resolutions of 
about 1cm.

Hiro


_______________________________________________
Brahms-dev-l mailing list
Brahms-dev-l@lists.bnl.gov
http://lists.bnl.gov/mailman/listinfo/brahms-dev-l