Hi devl's, I completely forgot, since my stay at BNL, with all these articles... I added some change to the BB vertex stuff (calibration and vertex module). I removed Flemming's temp hack (when one wanted a vertex using ALL tubes) and cleaned this option according to the structure of the object class. I just merged Hiro's change (if one wants to use small tubes only) although I realize one should maybe not disregard events where small tube vertices are not found...I'm not sure. I haven't committed yet. The reason is that the vertex offset corresponding to ALL tubes does not have any valid revision yet, whereas small, big and fastest tubes have. It's a bit unfortunate I just discover this change I introduced after 1 month but tell me if it's worth committing. Right now, the default is to select the vertex obtained from all tubes. With the clean code I want to introduce, this default is not wise as long as the DB is not filled with a revision. The reason I cleaned up the code in my brat 1 month ago is for readibility and consistency. So think twice before accepting the change :) Djam -- Djamel Ouerdane ------------------------------------------o | Niels Bohr Institute | Home: | | Blegdamsvej 17, DK-2100 Ø | Jagtvej 141 2D, | | Fax: +45 35 32 50 16 | DK-2200 Copenhagen N | | Tel: +45 35 32 52 69 | +45 35 86 19 74 | | http://www.nbi.dk/~ouerdane | | ouerdane@nbi.dk | o---------------------------------------------------------o _______________________________________________ Brahms-dev-l mailing list Brahms-dev-l@lists.bnl.gov http://lists.bnl.gov/mailman/listinfo/brahms-dev-lReceived on Tue Mar 16 10:44:39 2004
This archive was generated by hypermail 2.1.8 : Tue Mar 16 2004 - 10:44:55 EST