Re: [Brahms-dev-l] brat update

Hi,

I want to support Djamels statement, but with a modifier, since it is not
clear obvious to what degree
the code actually ever worked, so not tested can mean two things e.g. it
compiles, and does what it did before, but new features are still work in
progress- this is properly fine.

In general the guidelines are in the BratGuide. This is still mandatory
reading for developers (and users).
Just a few reminders

i) code MUST compile and execute before commiting. Make also sure that
   the revision major/minor numbers are updated.
ii) Send a message to the dev-list what is done.

The /opt/brahms/new is as said updated every midnite. If it does not compile
it will not be installed,
but no test are being run.

iii) When data classes are being modified , do remember to increment the
classdef number, otherwise
we get into problems with the reading of existing root files.

----------------------------------------------------------------
Flemming Videbaek
Physics Department
Brookhaven National Laboratory

e-mail: videbaek@bnl.gov
phone: 631-344-4106
----- Original Message ----- 
From: "Djamel Ouerdane" <ouerdane@nbi.dk>
To: "Eun-Joo Kim" <ejkim@ku.edu>
Cc: <brahms-dev-l@lists.bnl.gov>
Sent: Thursday, February 05, 2004 1:16 PM
Subject: Re: [Brahms-dev-l] brat update


> Ciao Eun-Joo,
>
>
> > in TOF calibration modules.
> > And BrMrsTfw2MatchingModule.
> > I have not tested all of them.
>
> Have you anyway committed your changes ? I don't want to argue too much
> about the matter since I haven't touched brat for a long time and have not
> been myself very strict with our policy but I would like to recall that
> changes to brat should done be after proper testing. As far as I know, the
> "new" tree is compiled on a daily basis automatically or so, proper
> testing should prevent us from having bad surprises.
>
> Djam
>
>
>
>
> -- 
> Djamel Ouerdane ------------------------------------------o
> |  Niels Bohr Institute      |  Home:                     |
> |  Blegdamsvej 17, DK-2100 Ø |  Jagtvej 141 2D,           |
> |  Fax: +45 35 32 50 16      |  DK-2200 Copenhagen N      |
> |  Tel: +45 35 32 52 69      |  +45 35 86 19 74           |
> |                  http://www.nbi.dk/~ouerdane            |
> |                  ouerdane@nbi.dk                        |
> o---------------------------------------------------------o
>
>
> _______________________________________________
> Brahms-dev-l mailing list
> Brahms-dev-l@lists.bnl.gov
> http://lists.bnl.gov/mailman/listinfo/brahms-dev-l
>


_______________________________________________
Brahms-dev-l mailing list
Brahms-dev-l@lists.bnl.gov
http://lists.bnl.gov/mailman/listinfo/brahms-dev-l