Hi Bjorn et al, On Thu, 13 Dec 2001 04:20:01 -0500 (EST) Bjorn H Samset <bjornhs@rcf2.rhic.bnl.gov> wrote concerning "Re: Another change prop. - BrVertexFilter ": > Eh, did you read the above? ;-) My problem is with the different vertex > measurements from the BB, not different detectors. The current code is the > following: > Ah, Ok I misread your mail - sorry. > I.e. _first_ check for a BbRdo. If this is found then use it. If not, then > look for a BrBbVertex. If my InNode for some reason contains both (as was > the case yesterday...) then the VertexFilter automagically decides for me > which one to use. I guess another option is to have separate tests for Rdo > and brVertex objects, and yet another is to fiddle around with > switchModules and appendContainers until I get what I want, but for now I > think the easiest is to just make it look for the most precise measurement > first: Well, I don't have any problem with that - that is checking the BrBbVertex first. I think that the old BrBbRdo is obsoleted by BrBbHit and you should probably remove the BrBbRdoModule from your pipeline. If you're using the BrGlobalPackage, then do globalPackage->RemoveModule(globalPackage->GetBbRdoModule()); At some point, I'll add the BrBbHitModule instead of BrBbRdoModule. I think BrBbVertexModule and BrTpmClusterModule (and BrZdcVertexModule?) should probably live in some other package, like BrVertexPackage. > Also note the implementation of a kDemandBbVertex, by default set to > fFALSE, that stops the pipeline if there is no BrBbVertex or BbRdo > present. That isn't really needed, since the BrBbRdo are obsolete. The only reason why it's in the filter is for backward compatiblity. > > > Plus some minor cleanup... > > > > What are those 'minor cleanup's? Please be more precise. > > Actually nothing - I saw some erraneous documentation in a prevoius > version of the code, but I see that you have corrected that already. > > (When is a programmer not precise? When he hasn't yet made the changes to > his own code ;-) Sorry, I don't get it. Yours, Christian Holm Christensen ------------------------------------------- Address: Sankt Hansgade 23, 1. th. Phone: (+45) 35 35 96 91 DK-2200 Copenhagen N Cell: (+45) 28 82 16 23 Denmark Office: (+45) 353 25 305 Email: cholm@nbi.dk Web: www.nbi.dk/~cholm
This archive was generated by hypermail 2b30 : Thu Dec 13 2001 - 09:10:34 EST