Hi Flemming and other devs I have fixed 2 problems introduced by me, sorry. In addition I have made fResiduals persistent again (I must have changed that by accident before) and tested the the BrTrackResidual addidtion to BrTpcTrackCandidate in detail. I first tagged brat 2-1-29 and then after finding some bugs tagged it BRAT-2-1-30 (so don't use 2-1-29). 1st problem : > I think the omission of a destructor in the 'BrTpcTrackCandidate and > deletion of elements in the > TObj array of the residuals is an oversigt, but I will let Peter fix > this since he is the author. There may be other ramifications I do not > know about . > > (a bratmain session grew from 32M -> 104M with ~70K trigger 6 events at > 30 deg.) > with the fix it all seems ok. I pledge guilty and have included Flemmings fix and a copyconstructor plus tested using TObjectTable that the residuals are removed. 2nd problem : >diff -r1.1 BrTpcDriftFibCalModule.h >35c35 >< const Int_t kMaxFibres; // max number of fibres >(currently 6) >--- >> Int_t kMaxFibres; // max number of fibres (currently 6) > >-- The gcc on sun complained about this const (an error that I know Steve >Sanders >also complained about) - Peter could you review what you want to do here. I changed the constant to an enum. ChangeLog : 2001-11-13 Peter H Christiansen <pchristi@rcas0013.rcf.bnl.gov> * configure.in: Tagged bra BRAT-2-1-30 * data/track/BrTpcTrackCandidate.cxx, data/track/BrTpcTrackCandidate.h: Made residuals persistent and fixed bugs in copyconstructor. 2001-11-13 Ouerdane Djamel <ouerdane@rcas0013.rcf.bnl.gov> * scripts/calib/Reco.C: added RICH in copy module 2001-11-13 Peter H Christiansen <pchristi@rcas0013.rcf.bnl.gov> * configure.in: Tagged new version of brat. * data/track/BrTpcTrackCandidate.cxx, data/track/BrTpcTrackCandidate.h: Added destructor to close memory leak (shame on me) and a copy constructor. * modules/track/tpc/BrTpcTrackModule.cxx: Changed definition of deviation histograms so it fills for all rows instead of just instrumented. * modules/calib/tpc/BrTpcDriftFibCalModule.h, modules/calib/tpc/BrTpcDriftFibCalMo\ dule.cxx: Changed const to enum to make it more compile friendly * scripts/calib/Makefile.am: Removed removed file from Makefile * scripts/calib/mult/.cvsignore: Adde cvsignore file 2001-11-13 Ouerdane Djamel <ouerdane@rcas0013.rcf.bnl.gov> * scripts/calib/Reco.C: added BFS stuff * scripts/calib/RecoBfs.C: merged with Reco.C -- :-) --------------------------------- )-: |Peter H L Christiansen aka PAN @ NBI | |EMAIL : pchristi@nbi.dk | |OFFICE : Tb1 @ NBI | |PHONE : 353 25269 | |SNAIL : Hans Tavsensgade 35, 4th | |PHONE : 35 349336 | :-D --------------------------------- \-:
This archive was generated by hypermail 2b30 : Tue Nov 13 2001 - 07:34:41 EST