Hi all, On Sat, 3 Nov 2001 09:25:54 +0100 (MET) Djamel Ouerdane <ouerdane@nbi.dk> wrote concerning "Re: event IO": > Ok, I've found the stuff that stopped the jobs: > > in BrMainModule.cxx, someone changed this: > > if (fStatus >= kStop) > continue; > > to that > > if (fStatus >= kStop) { > cout << "Begin Stopped " << endl; > return fStatus; > } A short comment on these kind of output: Please use one of TObject::Warning("<where">, "<format>", ...) TObject::Error("<where">, "<format>", ...) TObject::Fatal("<where">, "<format>", ...) BrModule::Stop("<where">, "<format>", ...) BrModule::Failure("<where">, "<format>", ...) BrModule::Abort("<where">, "<format>", ...) rather then writting to stdout/stderr directly. If you feel that any of the above messages is not what you want (but I can't imagine why), then at least protect your output with a debug or verbosity level, and _always_ say _where_ the print out is from, like if (DebugLevel() > 4 || Verbosity() > 9) cout << "<BrMainModule::Main>: some module failed in Begin" << " - giving up" << endl; That makes debugging easier for, especially if you're not the person that wrote the output statement - seeing "Begin Failed" on your term or in your log file is not very descriptive, since it could come from N places, where N is the number of modules (including BrMainModule) you have in your module pipeline. Please write informative error/debug/run messages - simply saying "now I'm here", "foo", "bar", "baz", is _not_ informative at all to any one but the bugger that wrote the stuff. So help others help you, and be informative. Yours, Christian Holm Christensen ------------------------------------------- Address: Sankt Hansgade 23, 1. th. Phone: (+45) 35 35 96 91 DK-2200 Copenhagen N Cell: (+45) 28 82 16 23 Denmark Office: (+45) 353 25 305 Email: cholm@nbi.dk Web: www.nbi.dk/~cholm
This archive was generated by hypermail 2b30 : Sun Nov 04 2001 - 11:16:57 EST