Hi Christian,
> > The modules/calib dir has a new subdir: vertex
> > The classes are (so far):
> > BrVertexCalModule (base class)
> > BrBbVertexCalModule
> >
> > (the TPC and ZDC are not yet available)
>
> Are they done and you're just holding back, or there's absolutely
> nothing yet?
There's nothing yet since I never tried to get a ZDC vertex. For the TPC
offset, I'm not sure I want to put it there since it's related to the
drift velocity fluctuation and Peter has already checked in some stuff for
this kind of calibration.
>
> >
> > The scripts/calib/bb dir. has 2 new scripts:
> > BbVtxOffset.C
> > CommitVtxOffset.C
>
> Please add calib to SUBDIRS in scripts/Makefile.am, and add
> scripts/calib/Makefile.am (and so on) which installs the scripts into
> $(BRATSCRIPTDIR). See "The Guide" and scripts/Makefile.am for further
> references.
Done. If you make install, the stuff will be put in
<install-dir>/share/brat/scripts/calib
> Did you intent to substitute the old BrBbRdoModule with these class or
> what?
I repeat here that when I first wrote the stuff, I intended to do so but
Flemming didn't want and renamed the classes (I'm not the one who renamed
the classes) for good reasons.
> If so, why don't you rename BrCalHitsModule to BrBbRdoModule an
> BrCalHits to BrBbRdo?
Flemming will tell you better than me.
> Also, did you make BrBbVertex derive from
> BrVertex (possibly defining a new class BrTpmVertex deriving from
> BrVertex to)?
Not yet, I haven't got the time...you know about it :)
>
> > I had to update configure.in and config/config.mk so that the
> > makefile sare generated and so on.
>
> What a surprise - there's nothing odd in this - see "The Guide".
I've never said it was odd ! :) I mentioned it because I did it like
everyone should do when adding a new dir to brat.
>
> > I've tested it and it gave me very nice results. I inserted into the
> > sql DB as a test the BB offset values for run 5036.
>
> What is "very nice results"?
>
no crash, nice peaks with small combinatorial background and I got the
expected resolution (around 0.65 cm for small tubes, 1.5 for big and 3 for
fastest). And it's really fast to run, 10k events with TPM1 tracks are
enough.
> As you perfectly well know, the revisions does not have a fixed size.
> In fact, it's designed so that one may change the number of parameters
> stored in a revision if the need arises (More slats in the TOFW is a
> good example). Hence, in so far as one calibration parameter (set) is
> all that's needed, there's little danger of making bad changes.
The nice thing with the BrCalibrationData is that you allocate yourself
the size you want in your calibration modules:
fCalibration->Use("param name", access-mode, nData);
in the ZDC offset module,one will have to set nData to 2 or more if
necessary. In fact, if I introduce the sigma, I will just have to add
twice more elements for each parameter and add proper methods to set and
get them. This dynamic allocation is really cool :)
Ciao
Djam
This archive was generated by hypermail 2b30 : Fri Nov 02 2001 - 21:18:39 EST