Peter H. L. Christiansen wrote: > BTW I had a look at Set(In)ActiveRow and they both call > SetActiveParameters which looks like it is deleting a lot arrays for no > reason. If you agree maybe we should change that. The other reason for > this is that it resets all pad parameters to Active which is not what I > would expect for this function. I tend to agree. The "lower part" of BrDetectorParamsTPC::SetActiveParameters (below the second comment) does not use any new information gained in the upper part. It is thus a waste to redo the default pad "activity map". I'd say these two parts don't belong together in the same method. Currently, however, one can not read the state of single pads from a file, like DetectorParameters.txt. Therefore, if one enables/disables rows before doing the same thing with single pads, one will not overwrite any setting, at least to my knowledge. Since this SetActiveParameters member function is called also in SetASCIIParameters and SetDefaultParams, one should have some way of setting default activity map. Also, I find it somewhat strange that a pad is set active even if its mother pad row is inactive. The state of single pads should in my opinion depend on the state of its mother pad row. I'll include the before mentioned small script in BRAT tomorrow. JI -- Jens Ivar Jřrdre e-mail: JensIvar.Jordre@fi.uib.no usually: Dep. of Phys., Allégt. 55, N-5007 BERGEN, NORWAY currently: Bldg 510D, P.O.Box 5000, Upton, NY 11973-5000, USA phone: +1-631-344-4223
This archive was generated by hypermail 2b30 : Thu Oct 11 2001 - 16:14:57 EDT