BrRawDataInput and C1

From: Djamel Ouerdane (ouerdane@nbi.dk)
Date: Tue Jul 31 2001 - 10:42:46 EDT

  • Next message: Christian Holm Christensen: "Suggestion for change of BrMultRdo (and BrTofRdo?)" 

    Hi,

I've just found in BrRawDataInput that the tube numbering starts at 0 fro
C1, this piece of code shows how BrC1Dig is filled:

	for(ihit=0;ihit<nhits;ihit++) {
	  BrRawEvent::mappedATBlkHit_t *hit = &mapped_at_blk_hits[ihit];
	  digc1_p->SetAdc(ihit,hit->adc);
	}                 ~~~~

for RICH we have:
	for(ihit=0;ihit<nhits;ihit++) {
	  BrRawEvent::mappedAdcBlkHit_t *hit = &mapped_adc_blk_hits[ihit];
	  digrich_p->SetAdc(ihit+1,*hit);
	}                   ~~~~~~   |
                                     |___ (is this ok ??)

and e.g. TOF1:

        for(ihit=0;ihit<nhits;ihit++) {
	   digtof_p->SetSlatno(ihit+1);
                               ~~~~~~

Someone talked about confusion recently, here is the kind of thing that
really introduces confusion to my opinion, especially if you check the
cherenkov tube mapping recently checked in (cf brat 2.0.18) where tube
numbers start from 1.

I would be for changing this in the C1 decoding part.
Since C1 was not used so far in the analyses, this change won't have a too
bad effect since C1 was useless or so in the old runs.

What do you think?

Djam


-- 
Djamel Ouerdane ------------------------------------------o
|  Niels Bohr Intstitute     |  Home:                     |
|  Blegdamsvej 17, DK-2100 Ø |  Jagtvej 141 2D,           |
|  Fax: +45 35 32 50 16      |  DK-2200 Copenhagen N      |
|  Tel: +45 35 32 52 69      |  +45 35 86 19 74           |
|                  http://www.nbi.dk/~ouerdane            |
|                  ouerdane@nbi.dk                        |
o---------------------------------------------------------o

    This archive was generated by hypermail 2b30 : Tue Jul 31 2001 - 10:43:53 EDT