Re: brop error message

From: Christian Holm Christensen (cholm@hehi03.nbi.dk)
Date: Fri Jul 27 2001 - 05:59:07 EDT

  • Next message: Djamel Ouerdane: "Geometry and magnet files"

    Hi Hiro, 
    
    On Fri, 27 Jul 2001 00:33:31 -0500 (CDT)
    Hironori Ito <hito@students.phsx.ukans.edu> wrote
    concerning ": brop error message":
    > 	Hello.  I have two questions.  The first one is whether there is
    > anyone who compiled brop with RH7.1 without error message.  I got the one
    > error message in BrOnlineMonitorTPC.cxx, which complain about
    > "exit" method.  I did not have this problem with RH6.2, so I assume that
    > it is by compiler.  Anyway, in my local program, I just added
    > "stdlib.h" header in the BrOnlineMonitorTPC.h, and the error is gone.  Is
    > this the only way (or right way) to get rid of this errorin RH7.1?  
    
    It's the right way to code this.  It seems that the GCC 2.91.66
    included the header "stdlib.h" automatically, and GCC(?) 2.96.0 does
    not.  
    
    What ever the compiler does, one _must_ always include the needed
    headers, if one wants portable code (cf. recent discussion on
    HIJING).  So the thing is to include "stdlib.h".  In fact, I recommend
    including it like this: 
    
      #ifndef WIN32 
      #ifndef __CSTDLIB__ 
      #include <cstdlib> 
      #endif 
      #else 
      #include <stdlib.h> 
      #endif 
    
    since the cstdlib header is the ANSI/ISO C++ one, and stdlib.h is the
    ANSI/ISO C one. 
    
    Please note the new elisp function in root-help called
    "sys-include-header": 
    
      M-x sys-include-header 
      Header name: my-header
      
    inserts: 
    
      #ifndef __MY-HEADER__ 
      #include <myheader> 
      #endif 
    
    
    > If it is, can a person who knows it add that header to the right
    > place? 
    
    Just at the top of the implementation file.  
    
    Havning said all this, no class (in all cases, not just BRAT, BROP,
    etc.) should use  "exit".  Instead signal some thing that the
    application should terminate.  In the BrMainModule bassed
    applications, this is done using "BrModule::Abort".  For other ROOT
    based classes, there's also the possibility of using
    "TObject::Fatal", "TApplication::Terminate" and so on. 
    
     The second one is that I get the error message when I do
    > "make install" in brop because it can not find a README directory.
    
    README directory? That's defently not what is in there.  It seems that
    you've not gotten that out of CVS.  Try 
    
      cvs update -P -d -A 
    
    and then make install again. 
    
    > (Note:  I specifies the "prefix=$HOME/brop")  
    
    This is of no consequence. 
    
    > Obviously, it is conflicting with README file of brop.  Anyway, in
    > my local pc, I renamed README to README.txt and created README
    > directory by myself.  And, it went fine.  Can someone rename README
    > file or the name of directory in the configuration? 
    
    README files should have just that name: README, not README.txt,
    README.TXT, 00README.TXT, readme.txt, 00readme.txt,
    if-you-do-not-read-me-you-will-be-fucked.txt, or anything like that!
    README is the name, and should stay that way. 
    
    The problem, was a final space in the definition of pkgdocdir of the
    top-level Makefile.am.  You've probably seen a message like 
    
     /README: no such directory. When installing multiple files,
     destination should be a directroy.  
    
    See also a recent email to brahms-dev-l on the same topic. 
    
    Yours, 
    
    Christian  -----------------------------------------------------------
    Holm Christensen                             Phone:  (+45) 35 35 96 91 
      Sankt Hansgade 23, 1. th.                  Office: (+45) 353  25 305 
      DK-2200 Copenhagen N                       Web:    www.nbi.dk/~cholm    
      Denmark                                    Email:       cholm@nbi.dk
    



    This archive was generated by hypermail 2b30 : Fri Jul 27 2001 - 05:59:44 EDT