Heigh ho :-) Now that I suddenly have lots of time on my hands (yeah right) I thought I'd get around to the long overdue cleanup of the TPC vertex code. Here is what I intend to do - please comment on anything that shold be done differently or additional changes. I'll create BrTPCVertexModule, a common base module for TPC vertex algorithms that handles filling of data objects etc. The two existing algorithms become BrTPCClusterVertexModule BrTPCTrackVertexModule and should function as before, except for the following changes: 1) I'll get rid of the SetDetectorHits/Tracks - all data will be taken from InputNode() 2) The parameters will be loaded via the module name instead of a third creator parameter (i.e. Name will have to be "TPM1") 3) My proposed cuts on well-determinedness will be included as default (settable, of course), and VertexFound will only be 1 if these criteria are met. I'll also add proper statistics histograms, which have been sadly lacking, and do some cleanup of the algorithms themselves. I hope to fix the y-problem with the ClusterVertex. BrVertex will be cleaned up a bit (should it be called BrVertex, or was the old name BrVertexData better?) BrVertexModule will be updated to reflect these changes, but I'd like some input on the future of this class. I intended it to be a common vertex class that looks for data from BB, ZDC, TPM1 and in the future TMS/SMA, and creates a BrVertex for each (either by picking an existing one or by using a VertexModule or RdoModule) and then possibly setting a flag on vertex consistency, (calculating a mean vertex?) etc. Is this a useful module, or will vertexing in any case be done "here and there" so that a common collector only adds confusion? Well - I expect there are some opinions on this ;-) The changes will be ready in a day or to, so do shout. Ping :-) ------------------------------------------------ Bjorn H. Samset Master-student in Heavy Ion physics Mob: +47 92 05 19 98 Office: +47 22 85 77 62 Adr: Kri 2A709 Sognsveien 218 0864 Oslo
This archive was generated by hypermail 2b29 : Mon May 14 2001 - 05:30:52 EDT