Hi Björn, On Tue, 6 Feb 2001 08:08:36 -0500 (EST) Bjorn H Samset <bjornhs@rcf.rhic.bnl.gov> wrote concerning ": New BrRdoModuleZDC in brat": > > Howdy y'all. (Trying to sound like a Texan...) Uh. I seem to remember some discussion some time ago about how to do that greating properly. Check out thread starting at http://www.rhic.bnl.gov/brahms/WWW/private/list_hyper/brahms-soft-l/0045.html > I've checked in a new and bigfixed version of BrRdoModuleZDC and BrRdoZDC > in CVS. Great - thank you very much. > As before, this version has the slewing corrections done by Andrei > Makeev (hardcoded for now), but it also has some important bugfixes and > changes: > > 1) The "old" GetAdcTdc is back, in case someone wants to use older code > (the new commands are also there of course) > 2) The event bias introduced by the first module saturating is removed, > i.e. statistics and event selection from the ZDC is now as before. > 3) IMPORTANT --- vertex offset!!! > The old modules have all had an offset of 107 cm hardcoded in them. This > is now REMOVED, as it was an ah-hoc fix done last summer and never > intended to be permanent. Instead, there is a function > void SetPosOffset(const Float_t value) > that can set an offset. An offset is still needed (I'm not sure why...), > and the value I'm using is 26.5 cm. I.e. use teh command > zdcRdoModule->SetPosOffset(26.5); Could you please make 26.5 the default argument BrRdoModuleZDC::SetPosOffset and call that in the CTOR BrRdoModuleZDC, like BrRdoModuleZDC::BrRdoModuleZDC(const Char_t* name, const Char_t* title) : BrModule(name, title) { TdcCount = 100.0e-12; SetPosOffset(); } so that one may use the module blindly. I believe this is the simplest way of setting default arguments, since you only need to update them in one place i.e., the header. > This should make the ZDC's agree with both BB and TPM1. Great. Yours, Christian ----------------------------------------------------------- Holm Christensen Phone: (+45) 35 35 96 91 Sankt Hansgade 23, 1. th. Office: (+45) 353 25 305 DK-2200 Copenhagen N Web: www.nbi.dk/~cholm Denmark Email: cholm@nbi.dk
This archive was generated by hypermail 2b29 : Tue Feb 06 2001 - 08:42:57 EST