"I. G. Bearden" wrote: > Flemming Videbaek wrote: > >> As some of you may have discovered (I know of 3) the BrRdoModuleBB >> does not compile within BRAT. To make this a) removed TickLength >> from being a global constant (in BrRdoModule.h)b) pickup the value >> from the BrDetctorParamsBB fParams_p->GetTdcConv() that already has >> this infromation as a standard. This will also make it easier to >> convert later to proper DB calibrations. Yury, Please before >> committing new code to CVS follow the standard way of ensuring code >> quality do a clean make for the sub-directories (e.g. bb cd >> bb/src make clean make If all of Brat is checked out do this for >> the total Brat system and run the default test programs. >> ------------------------------------------------------ > > As one of the three mentioned by Flemming, I was more than a little > peeved by this. > I tried to reread the email describing what had been commited, but in > the brahms-dev archive > Yury's mails are a bit garbled. If you know why, please fix the > problem for future communications. > > Another problem with the code, as delivered, is that the histograms > are booked in the > Book() method, as they should be, but they are then filled whether or > not they were > created...I solved this by using the ->Book(), but only after the > first crash. > > I am also curious about the calibrations. Where they done for > run2054, as stated in the file, or some later > run? Do you know yet how stable these calibrations are over time? > > After fixing (in my usual half-assed way, I'm sure!) the problems that > I have found so far, the RdoModule > seems to work rather nicely. Thanks! > >> >> Dr. Flemming Videbaek >> Physics Department >> Brookhaven National Laboratorytlf: 631-344-4106 >> e-mail: videbaek@bnl.gov > > -- > Ian-------------------------------------------------------------------- > | I.G. Bearden | > | Niels Bohr Institute Tb 3 email: bearden@nbi.dk | > | Blegdamsvej 17 phone: (+45) 35 32 53 23 | > | København Ø FAX: (+45) 31 42 10 16 | > | Danmark | > ---------------------------------------------------------------------- > > -- Ian-------------------------------------------------------------------- | I.G. Bearden | | Niels Bohr Institute Tb 3 email: bearden@nbi.dk | | Blegdamsvej 17 phone: (+45) 35 32 53 23 | | København Ø FAX: (+45) 31 42 10 16 | | Danmark | ----------------------------------------------------------------------
This archive was generated by hypermail 2b29 : Wed Oct 25 2000 - 11:25:25 EDT