September 16. The internals of BrDetectorVolume has been modified. The 'old' rotation matrices are now gone. The angle alone for a volume is not sufficient. A complete rotation matrix is needed. The reading from ascii file sets the rotation matrix as needed. Some of the BrDetector<xxx>. classes do not work since they read back the angle. In the course of this a couple of problems were also discovered in BrRotMatrix (need an assignment operator to work with ROOTCINT) the default is not enough. I have removed references to GetAngle in the Brat code and replaced by a rotation matrix call to getting an Euler angle. Again most likely this is not what you want. For you (Kris) who wrote the BaseDetector clas and the derived one could you take a look at this. Do also note that if macro's other programs are using refernces to vol->GetAngle() and vol->GetPos() these are now obsolete and deleted. Float* getPos() replace by BrVector3D* GetPosition(); Other routines have had minor cosmetics performed. Improving Listing and os << operator. All together following code has been changed. base/.../ BrDetectorVolume.cxx BrDetectorVolume.h geometry/.. BrRotMatrix.h BrVector3D.h BrRotMatrix.cxx I noted that the Euler angles are NOT set properly for some of the operations (e.g. implied Mult (rot1,rot2), SetMatrix(..) neither in the SetInverseMatrix in the BrCoordinateSystem A Test macro/Program has been added to brat/test TestDetectorVolume. The brat-config updated to reflect 1.10.0 - i.e. not a bug fix but change of some class method's. These changed has been made so we can study effects of 'small' tilts of TPM1 and TPM2 and optimize the matching. It is also a preparation for a more general Volume description, where this class is a base class for all real detectors. As an added benifit the previous empty pointer to the GeantTrack in BrGeantHit is now filled by default in BrGeantInput->Event(); ------------------------------ Flemming Videbaek Physics Department Brookhaven National Laboratory tlf: 631-344-4106 fax: 631-344-1334 videbaek@bnl.gov
This archive was generated by hypermail 2b29 : Mon Sep 18 2000 - 17:46:27 EDT