Re: Minor tracking class updates

From: Christian Holm Christensen (cholm@hehi03.nbi.dk)
Date: Fri Jun 23 2000 - 07:36:54 EDT

  • Next message: Djamel Ouerdane: "Re: Minor tracking class updates" 

    Hi Trine et al, 

On Fri, 23 Jun 2000 12:52:52 +0200 (MET DST) trine@lynx.uio.no (Trine Tveter) wrote:
> from dense groupings of hits in a few padrows.  
> - Added member fFindTracksMethod and function SetFindTracksMethod( int )
> (1 or 2)

May I suggest that you use nested enum's for these kind of purposes
(that is, options). I.e, instead of using the literate (unsigned)
integers 1L and 2L, you could instead define:

  class BrTrackStringFinder : ... {
  public: 
    enum EFinderMethod {
      kMethodOne, // the names should be more descriptive ofcourse
      kMethodTwo
    };
    ...
  };


An the prototype (or signature or whatever) of 
"BrTrackStringFinder::SetFindTracksMethod()" should be modified to 

  BrTrackStringFinder::SetFindTracksMethod(EFinderMethod method);

and one would send that message to an onbject "f" of the
BrTrackStringFinder class by:

  f.SetFindTracksMethod(BrTrackStringFinder::kMethodOne);

or 

  f.SetFindTracksMethod(BrTrackStringFinder::kMethodTwo);

This way of sending that message is certainly more descriptive, and,
it turns out, more robust, since you'll do checks against symbolic
values rather then literal values (which is notoriously error prone). 

The class "BrTrackStringFinder" isn't the only class in BRAT that
could take advantage of that sort of options. 

Just two pennies worth. 

On a side note: I'll be going to CERN this Monday for 11 weeks, and
while I'll be avaliable via Email, I'll probably not do a tremedious
amount of work on BRAT and related software. Ofcourse, I'll be happy
to answer any questions you may have regarding database stuff and so
on, and I'll still read brahms-dev-l, brahms-soft-l, and brahms-l, as
well as keeping in touch with the NBI group (whom I hope will drop me
a note from time to time on the general status of BRAHMS). 

For now, I hope this will prove to be a fruitful summer, and BRAHMS
will take an aboundance of data for us to analyse this fall. So ...

   A VERY NICE SUMMER TO YOU ALL!!!  

Cheers, 

Christian  -----------------------------------------------------------
Holm Christensen                             Phone:  (+45) 35 35 96 91 
  Sankt Hansgade 23, 1. th.                  Office: (+45) 353  25 305 
  DK-2200 Copenhagen N                       Web:    www.nbi.dk/~cholm    
  Denmark                                    Email:       cholm@nbi.dk

    This archive was generated by hypermail 2b29 : Fri Jun 23 2000 - 07:41:16 EDT